Skip to content

Conversation

Rican7
Copy link
Collaborator

@Rican7 Rican7 commented Jan 23, 2015

(Re-targeted version of #490)

This PR sets the MySQL sql_mode to a strict setting for our tests.

We do this in two ways/places:

  • Set it globally for Travis-CI, since we want all travis tests to be strict and we don't care about messing with the environment since its temporary anyway
  • Set it for the session when testing locally, so that it doesn't change your local MySQL configuration semi-permanently (which may be used for other local DB's)

Setting the sql_mode in this way should make our testing more reliable and will most likely even restore the seemingly vanished bug described in #438 (that was originally fixed in #317 and then again in #440).

@koenpunt koenpunt force-pushed the 1.1-dev branch 2 times, most recently from 494d55e to 352e1b6 Compare June 3, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant